Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add version byte to PayloadBuilderAttributes::try_new #12135

Closed
mattsse opened this issue Oct 28, 2024 · 1 comment
Closed

Add version byte to PayloadBuilderAttributes::try_new #12135

mattsse opened this issue Oct 28, 2024 · 1 comment
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Oct 28, 2024

Describe the feature

TODO

  • add version: u8 as argument to

    reth/crates/payload/primitives/src/traits.rs

    Lines 85 to 88 in 0d07d27

    /// Creates a new payload builder for the given parent block and the attributes.
    ///
    /// Derives the unique [`PayloadId`] for the given parent, attributes and version.
    fn try_new(

we want byte here because then this doesn't bake in EngineApi

cc @0xOsiris

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Oct 28, 2024
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started and removed S-needs-triage This issue needs to be labelled labels Oct 28, 2024
@edisontim
Copy link
Contributor

hello! Happy to work on this!

@0xOsiris 0xOsiris mentioned this issue Oct 28, 2024
Merged
@mattsse mattsse closed this as completed Oct 28, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattsse @edisontim