Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate PayloadBuilder into Rpc #12426

Closed
mattsse opened this issue Nov 9, 2024 · 0 comments · Fixed by #12428
Closed

Integrate PayloadBuilder into Rpc #12426

mattsse opened this issue Nov 9, 2024 · 0 comments · Fixed by #12428
Assignees
@mattsse
Labels
C-enhancement New feature or request S-needs-triage This issue needs to be labelled

Comments

@mattsse
Copy link
Collaborator

mattsse commented Nov 9, 2024

Describe the feature

we'd like to use the payloadbuilder for building the pending block which would clean up a lot of things.

for this we need:

add a payloadbuilder associated type to

reth/crates/rpc/rpc-eth-api/src/node.rs

Line 12 in 4d3d552

pub trait RpcNodeCore: Clone + Send + Sync {
same as

reth/crates/node/api/src/node.rs

Line 65 in 4d3d552

type PayloadBuilder: PayloadBuilder + Clone;

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Nov 9, 2024
@mattsse mattsse self-assigned this Nov 9, 2024
@mattsse mattsse mentioned this issue Nov 9, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattsse mattsse

Labels
C-enhancement New feature or request S-needs-triage This issue needs to be labelled
Projects
Reth Tracker
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add PayloadBuilder to RpcNodeCore paradigmxyz/reth
1 participant
@mattsse