Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support queuing multi-block downloads and executing ranges of blocks after a forkchoice update #3117

Closed
Rjected opened this issue Jun 13, 2023 · 2 comments
Assignees
Labels
A-blockchain-tree Related to sidechains, reorgs and pending blocks C-enhancement New feature or request
Milestone

Comments

@Rjected
Copy link
Member

Rjected commented Jun 13, 2023

Describe the feature

Currently we only support queuing single block downloads via the FullBlockDownloader. With #3059 we will have a heuristic for the number of blocks that need to be downloaded and executed to validate a forkchoice update. This is done by first fetching the head or safe block hash, and comparing the block number with the latest valid finalized block.

Instead of downloading the missing blocks one-by-one, we should support requesting ranges of blocks, since #3059 will already use the block number range to determine whether or not we should run the pipeline. This is more efficient than traversing the missing parents one-by-one.

Additional context

No response

@Rjected Rjected added C-enhancement New feature or request A-blockchain-tree Related to sidechains, reorgs and pending blocks labels Jun 13, 2023
@mattsse
Copy link
Collaborator

mattsse commented Jun 20, 2023

we definitely need to do this, ideally if range is larger than x blocks, perhaps even as low as 4, but really depends on how fast we can execute them.

the responses need to be yielded with increasing block number so they can be appended to the chain.
somewhat related: #3276

@Rjected Rjected self-assigned this Jun 24, 2023
@Rjected Rjected added this to the 0.1.0-alpha.2 milestone Jun 24, 2023
@onbjerg onbjerg modified the milestones: 0.1.0-alpha.2, 0.1.0-alpha.3 Jun 26, 2023
@onbjerg onbjerg modified the milestones: 0.1.0-alpha.3, 0.1.0-alpha.2 Jun 29, 2023
@onbjerg
Copy link
Member

onbjerg commented Jul 9, 2023

Closed in #3416

@onbjerg onbjerg closed this as completed Jul 9, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-blockchain-tree Related to sidechains, reorgs and pending blocks C-enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

3 participants