Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save pruning checkpoints in a separate database table #3432

Closed
Tracked by #3428
shekhirin opened this issue Jun 27, 2023 · 0 comments · Fixed by #3628
Closed
Tracked by #3428

Save pruning checkpoints in a separate database table #3432

shekhirin opened this issue Jun 27, 2023 · 0 comments · Fixed by #3628
Assignees
@shekhirin
Labels
A-db Related to the database A-pruning Related to pruning or full node C-enhancement New feature or request
Milestone
0.1.0-alpha.4

Comments

@shekhirin
Copy link
Collaborator

shekhirin commented Jun 27, 2023 •
edited
Loading

Describe the feature

We need to persist prune mode and the highest pruned block number in database. It needs to be done per prune part, and not per stage.

Prune mode needs to be persisted for two reasons

  • Now, check on startup that current pruning configuration matches previously used.
  • In the future, backfill data if the pruning configuration has changed.

Additional context

No response
@shekhirin shekhirin mentioned this issue Jun 27, 2023
Closed
@shekhirin shekhirin added C-enhancement New feature or request A-db Related to the database A-pruning Related to pruning or full node labels Jun 27, 2023
@onbjerg onbjerg added this to the 0.1.0-alpha.3 milestone Jun 29, 2023
@shekhirin shekhirin mentioned this issue Jul 6, 2023
Merged
@shekhirin shekhirin self-assigned this Jul 6, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shekhirin shekhirin

Labels
A-db Related to the database A-pruning Related to pruning or full node C-enhancement New feature or request
Projects
Reth Tracker
Archived in project
Milestone
0.1.0-alpha.4
Development

Successfully merging a pull request may close this issue.

feat(primitives, storage): save prune checkpoints in database paradigmxyz/reth
2 participants
@shekhirin @onbjerg