Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Populate error field in parity traces #3619

Closed
mattsse opened this issue Jul 6, 2023 · 3 comments
Closed

Populate error field in parity traces #3619

mattsse opened this issue Jul 6, 2023 · 3 comments
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jul 6, 2023

Describe the feature

this is a followup to

#3611

if a call failed (success field) the error should contain the error string:

ref https://github.com/ledgerwatch/erigon/blob/eae2d9a79cb70dbe30b3a6b79c436872e4605458/cmd/rpcdaemon/commands/trace_adhoc.go#L393-L408

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started A-rpc Related to the RPC implementation labels Jul 6, 2023
@mattsse
Copy link
Collaborator Author

mattsse commented Jul 6, 2023

@cjeva10 do you want to take this?

@cjeva10
Copy link
Contributor

cjeva10 commented Jul 6, 2023 •
edited
Loading

Opened #3627.

@onbjerg
Copy link
Member

onbjerg commented Jul 11, 2023

Closed in #3627

@onbjerg onbjerg closed this as completed Jul 11, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@onbjerg @mattsse @cjeva10