reth's callTracer output is different from erigon/geth's traces when a tx executes the SELFDESTRUCT opcode

[pnnkr]

Describe the bug

See relevant geth issue there: ethereum/go-ethereum#16459 - I think it's important for reth to return outputs as identical as possible to 90% of the other nodes out there.

Steps to reproduce

Consider the following TX on Goerli testnet: 0x389fed47c06d9e9c15e075339a2c820f009ba130165e58b95c757b51e25e5597. 0.01ETH is transferred by this TX via the SELFDESTRUCT opcode.

If you run debug_traceTransaction in erigon and geth, you get from both nodes:

$ curl -H "Content-Type: application/json"  --data '{"jsonrpc":"2.0", "method": "debug_traceTransaction", "params": ["0x389fed47c06d9e9c15e075339a2c820f009ba130165e58b95c757b51e25e5597",  {"tracer": "callTracer"}],"id":1}'  127.0.0.1:8545
{
  "jsonrpc": "2.0",
  "id": 1,
  "result": {
    "from": "0x208c016d29599bbb836e02f30798578e75bb62a0",
    "gas": "0x54a1",
    "gasUsed": "0x6f46",
    "to": "0x6c3782df9e7e0b6e723e7debbc1c690afb258009",
    "input": "0x43d726d6",
    "calls": [
      {
        "from": "0x6c3782df9e7e0b6e723e7debbc1c690afb258009",
        "gas": "0x0",
        "gasUsed": "0x0",
        "to": "0x208c016d29599bbb836e02f30798578e75bb62a0",
        "input": "0x",
        "value": "0x2386f26fc10000",
        "type": "SELFDESTRUCT"
      }
    ],
    "value": "0x0",
    "type": "CALL"
  }
}

If you run it from reth, you are missing the call with the value 0x2386f26fc10000 making it impossible to know that 0.01ETH was transferred:

$ curl -H "Content-Type: application/json"  --data '{"jsonrpc":"2.0", "method": "debug_traceTransaction", "params": ["0x389fed47c06d9e9c15e075339a2c820f009ba130165e58b95c757b51e25e5597",  {"tracer": "callTracer"}],"id":1}'  127.0.0.1:8545
{                                                                                                                                                                                                                                                                                           
  "jsonrpc": "2.0",                                                                                                                                                                                                                                                                         
  "result": {                                                                                                                                                                                                                                                                               
    "from": "0x208c016d29599bbb836e02f30798578e75bb62a0",                                                                                                                                                                                                                                   
    "gas": "0xa6e9",                                                                                                                                                                                                                                                                        
    "gasUsed": "0x1cfe",                                                                                                                                                                                                                                                                    
    "to": "0x6c3782df9e7e0b6e723e7debbc1c690afb258009",                                                                                                                                                                                                                                     
    "input": "0x43d726d6",                                                                                                                                                                                                                                                                  
    "output": "0x",                                                                                                                                                                                                                                                                         
    "value": "0x0",                                                                                                                                                                                                                                                                         
    "type": "CALL"                                                                                                                                                                                                                                                                          
  },                                                                                                                                                                                                                                                                                        
  "id": 1                                                                                                                                                                                                                                                                                   
}

Node logs

N/A

Platform(s)

Linux (x86)

What version/commit are you on?

v0.1.0-alpha.4

What database version are you on?

v0.1.0-alpha.4

If you've built Reth from source, provide the full command you used

cargo build --profile maxperf --features jemalloc

Code of Conduct

• I agree to follow the Code of Conduct

[github-actions]

This issue is stale because it has been open for 14 days with no activity.

[mattsse]

this should be fixed now

[pnnkr]

Amazing thanks!

I don't have time to test but you guys should check there's no similar issues with failed optimism l1 -> l2 TXs too (type 126).