Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slim down reth-primitives crate by extracting fork types to standalone crate #5524

Closed
mattsse opened this issue Nov 21, 2023 · 2 comments
Closed

Slim down reth-primitives crate by extracting fork types to standalone crate #5524

mattsse opened this issue Nov 21, 2023 · 2 comments
Assignees
@Arindam2407
Labels
C-debt Refactor of code section that is hard to understand or maintain C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Nov 21, 2023

Describe the feature

the crate is currently a bit bloated and it includes things that are useful on its own.

This includes:

  • Hardfork + ForkId etc..

TODO

  • Extract Hardfork + Forkid to new crate reth-ethereum-forks

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started C-debt Refactor of code section that is hard to understand or maintain labels Nov 21, 2023
@Arindam2407
Copy link
Contributor

I can take this

@mattsse
Copy link
Collaborator Author

mattsse commented Nov 22, 2023

I think the only real road bump are these functions:

reth/crates/primitives/src/hardfork.rs

Line 54 in 226eb86

pub fn fork_id(&self, spec: &ChainSpec) -> Option<ForkId> {

which I guess we should flip so that they are functions of ChainSpec instead of functions of Hardfork

This was referenced Nov 26, 2023
Closed
Merged
@mattsse mattsse mentioned this issue Dec 13, 2023
Closed
@mattsse mattsse closed this as completed Feb 1, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arindam2407 Arindam2407

Labels
C-debt Refactor of code section that is hard to understand or maintain C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattsse @Arindam2407