-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract reth-trie-types from reth-trie #8514
Comments
mattsse
added
C-enhancement
New feature or request
S-needs-triage
This issue needs to be labelled
labels
May 30, 2024
mattsse
added
C-debt
Refactor of code section that is hard to understand or maintain
A-db
Related to the database
and removed
S-needs-triage
This issue needs to be labelled
labels
May 30, 2024
I'd love to take this |
This issue is stale because it has been open for 21 days with no activity. |
github-actions
bot
added
the
S-stale
This issue/PR is stale and will close with no further activity
label
Jun 26, 2024
This issue was closed because it has been inactive for 7 days since being marked as stale. |
shekhirin
removed
the
S-stale
This issue/PR is stale and will close with no further activity
label
Jul 31, 2024
This was referenced Jul 31, 2024
Solved by #10008 Can be closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the feature
reth-trie mixes db implementations with type definitions, which is problematic if we want to use these types in evm for different targets (risc, maybe even no_std).
hence we should extract the core types to a standalone crate, primarily the TrieUpdates type
currently this type has functions that make use of db:
reth/crates/trie/trie/src/updates.rs
Line 132 in f43ccc7
or
reth/crates/trie/trie/src/updates.rs
Lines 114 to 119 in f43ccc7
The triewalker functions could be inverted and implemented on triewalker instead,
for the flush function we could use a tmp wrapper type instead
Additional context
No response
The text was updated successfully, but these errors were encountered: