Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove per block deletion limits in pruner #9445

Closed
shekhirin opened this issue Jul 11, 2024 · 2 comments · Fixed by #9446
Closed

Remove per block deletion limits in pruner #9445

shekhirin opened this issue Jul 11, 2024 · 2 comments · Fixed by #9446
Assignees
Labels
A-pruning Related to pruning or full node C-debt Refactor of code section that is hard to understand or maintain

Comments

@shekhirin
Copy link
Collaborator

Describe the feature

We don't need per-block deletion limits in our pruner, because freelist isn't an issue anymore.

Before, it was introduced to not prune too many blocks, so that data from new blocks occupies >= pages in the database that was pruned.

Now, we don't care about freelist growing, so we can set the deletion limits per run, and remove all logic related to block accounting.

Additional context

No response

@shekhirin shekhirin added C-debt Refactor of code section that is hard to understand or maintain A-pruning Related to pruning or full node labels Jul 11, 2024
@shekhirin shekhirin self-assigned this Jul 11, 2024
@shekhirin shekhirin changed the title Remove per block limits in pruner Remove per block deletion limits in pruner Jul 11, 2024
@emhane
Copy link
Member

emhane commented Jul 11, 2024

why don't we care ab freelist anymore?

@shekhirin
Copy link
Collaborator Author

why don't we care ab freelist anymore?

the size doesn't affect performance anymore, so we can grow it as much as we want, and new data will occupy the freed pages when needed

@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-pruning Related to pruning or full node C-debt Refactor of code section that is hard to understand or maintain
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants