Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle tree errors gracefully #9688

Closed
Tracked by #8742
mattsse opened this issue Jul 22, 2024 · 2 comments · Fixed by #9981
Closed
Tracked by #8742

handle tree errors gracefully #9688

mattsse opened this issue Jul 22, 2024 · 2 comments · Fixed by #9981
Assignees
Labels
C-debt Refactor of code section that is hard to understand or maintain

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jul 22, 2024

we currently have some unwraps:

self.buffer_block_without_senders(block).unwrap();
PayloadStatus::from_status(PayloadStatusEnum::Syncing)
} else {
let mut latest_valid_hash = None;
let status = match self.insert_block_without_senders(block).unwrap() {

TODO

  • handle them gracefully
@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Jul 22, 2024
@TropicalDog17
Copy link
Contributor

Hi, can I work on this issue @mattsse

@mattsse
Copy link
Collaborator Author

mattsse commented Jul 22, 2024

hey @TropicalDog17

ty, but this is a bit nuanced and moving quickly, and I'm currently on this already.

feel free to pick another good first issue, if you don't find anything, feel free to also ping me on tg

@mattsse mattsse assigned mattsse and unassigned mattsse Jul 22, 2024
@Rjected Rjected self-assigned this Jul 25, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants