chore: use correct type in getAccount
#10023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvares
commented
Aug 2, 2024
| @@ -8,6 +8,7 @@ use reth_codecs::{reth_codec, Compact}; | |||
| use revm_primitives::{AccountInfo, Bytecode as RevmBytecode, JumpTable}; | |||
| use serde::{Deserialize, Serialize}; | |||
|
|
|||
| pub use alloy_consensus::Account as AccountTrie; | |||
There was a problem hiding this comment.
Sincerely, I don't think this name is idiomatic. I think we can found a better name for it 👍🏻
mvares
requested review from
mattsse,
Rjected,
emhane and
joshieDo
as code owners
mattsse
requested changes
Aug 2, 2024
crates/rpc/rpc-eth-api/src/core.rs
Outdated
| @@ -250,7 +250,7 @@ pub trait EthApi { | |||
|
|
|||
| /// Returns the account details by specifying an address and a block number/tag | |||
| #[method(name = "getAccount")] | |||
| async fn get_account(&self, address: Address, block: BlockId) -> RpcResult<Account>; | |||
| async fn get_account(&self, address: Address, block: BlockId) -> RpcResult<AccountTrie>; | |||
There was a problem hiding this comment.
Suggested change
| async fn get_account(&self, address: Address, block: BlockId) -> RpcResult<AccountTrie>; | |
| async fn get_account(&self, address: Address, block: BlockId) -> RpcResult<reth_rpc_types::Account>; |
crates/rpc/rpc-eth-api/src/core.rs
Outdated
| @@ -626,7 +626,7 @@ where | |||
| } | |||
|
|
|||
| /// Handler for: `eth_getAccount` | |||
| async fn get_account(&self, _address: Address, _block: BlockId) -> RpcResult<Account> { | |||
| async fn get_account(&self, _address: Address, _block: BlockId) -> RpcResult<AccountTrie> { | |||
There was a problem hiding this comment.
Suggested change
| async fn get_account(&self, _address: Address, _block: BlockId) -> RpcResult<AccountTrie> { | |
| async fn get_account(&self, _address: Address, _block: BlockId) -> RpcResult<reth_rpc_types::Account> { |
mattsse
approved these changes
Aug 2, 2024
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9637