feat: add block_body_indices for BlockchainProvider2 #10106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
added
C-bug
Rjected
requested review from
rakita,
joshieDo,
shekhirin,
onbjerg,
fgimenez,
mattsse and
rkrasiuk
as code owners
mattsse
requested changes
Aug 6, 2024
| self.database.block_body_indices(number) | ||
| if let Some(indices) = self.database.block_body_indices(number)? { | ||
| Ok(Some(indices)) | ||
| } else if self.canonical_in_memory_state.hash_by_number(number).is_some() { |
There was a problem hiding this comment.
this should also use the BlockState and traverse its parent blocks for this and the anchor block number to read the indices from disk
Rjected
force-pushed
the
dan/add-block-body-indices-provider-two
branch
from
ae7bb25
to
d04050b
Compare
mattsse
reviewed
Aug 7, 2024
| let mut parent_chain = state.parent_state_chain(); | ||
| parent_chain.reverse(); | ||
| let anchor_num = state.anchor().number; | ||
| let mut stored_indices = self |
There was a problem hiding this comment.
If I'm reading this correctly, then we need to do a + 1 here on the first_tx_num
reth/crates/stages/stages/src/stages/bodies.rs
Lines 127 to 128 in 48d4c79
mattsse
approved these changes
Aug 7, 2024
mattsse
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like some review on the correctness of this method, specifically whether or not
next_txis accurate. Previously this would just go to the database, when it should be possible to fetch block body indices for the in memory canonical state.