Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only use tags if they have been set #10150

Merged
merged 3 commits into from
Aug 6, 2024
Merged

fix: only use tags if they have been set #10150

merged 3 commits into from
Aug 6, 2024

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Aug 6, 2024

Previously we would use the finalized block as the safe block, and we would also return block 0 as the finalized block even if no FCU has been sent.

Fixes the RPC: Safe Block on SafeBlockHash Update and RPC: Finalized Block on FinalizedBlockHash Update tests

@Rjected Rjected added C-bug An unexpected or incorrect behavior A-rpc Related to the RPC implementation A-db Related to the database A-blockchain-tree Related to sidechains, reorgs and pending blocks labels Aug 6, 2024
mattsse
mattsse approved these changes Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@Rjected Rjected added this pull request to the merge queue Aug 6, 2024
Merged via the queue into main with commit fbebde6 Aug 6, 2024
32 checks passed
@Rjected Rjected deleted the dan/rpc-safe-initialized-none branch August 6, 2024 19:34
martinezjorge pushed a commit to martinezjorge/reth that referenced this pull request Aug 7, 2024
@Rjected @martinezjorge
fix: only use tags if they have been set (paradigmxyz#10150)
3ffef6e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

Assignees
No one assigned
Labels
A-blockchain-tree Related to sidechains, reorgs and pending blocks A-db Related to the database A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rjected @mattsse