fix: use in memory state for state_by_block_number_or_tag #10152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
added
C-bug
Rjected
requested review from
joshieDo,
rkrasiuk,
rakita and
shekhirin
as code owners
mattsse
requested changes
Aug 6, 2024
Comment on lines
986
to
991
| let hash = self | ||
| .canonical_in_memory_state | ||
| .hash_by_number(num) | ||
| .ok_or_else(|| ProviderError::HeaderNotFound(num.into()))?; |
There was a problem hiding this comment.
this only looks at the tree but could also be an older block on disk
mattsse
approved these changes
Aug 6, 2024
Rjected
force-pushed
the
dan/fix-storage-at
branch
from
bb20c40
to
e06d007
Compare
martinezjorge
pushed a commit
to martinezjorge/reth
that referenced
this pull request
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this would only look at the database, when we may want to look in memory for state. For example, in
eth_getStorageAtwe use this method. The auto implementation is removed, and implemented directly on the old tree. The new tree now usesstate_by_block_hash.This fixes numerous
cancun/tests