Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce EngineApiRequest type #10158

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 7, 2024

closes #10098

this makes it possible to introduce additional request variants that the tree can handle, for example insert an executed block manually, which will be useful if we want to insert our own built block

Copy link
Member

@fgimenez fgimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse added this pull request to the merge queue Aug 7, 2024
Merged via the queue into main with commit 7ec3b92 Aug 7, 2024
34 checks passed
@mattsse mattsse deleted the matt/introduce-engine-api-request-type branch August 7, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bubble up download event from engineHandler
2 participants