feat(engine-util): reorg interceptor #10173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkrasiuk
added
A-consensus
rkrasiuk
requested review from
mattsse,
Rjected,
onbjerg,
fgimenez and
gakonst
as code owners
rkrasiuk
force-pushed
the
rkrasiuk/reorg-engine-interceptor2
branch
from
fc4cf05
to
cd22aea
Compare
mattsse
approved these changes
Aug 7, 2024
Comment on lines
+154
to
+155
| // TODO: This is an expensive blocking operation, ideally it's spawned | ||
| // as a task so that the stream could yield the control back. |
There was a problem hiding this comment.
should be okay for debugging
crates/engine/util/src/reorg.rs
Outdated
| &mut block_env, | ||
| chain_spec, | ||
| &reorg_target.header, | ||
| U256::MAX, // TODO: |
There was a problem hiding this comment.
this is okay because no longer relevant for beacon consensus
rkrasiuk
commented
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supersedes #8110.
Create a stream wrapper that can simulate reorgs for block n based on the contents of block n + 1.