-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reth-eth-types
: Do not import JsInspectorError
by default
#10202
reth-eth-types
: Do not import JsInspectorError
by default
#10202
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's also disable default features for this on workspace level and then enable it when where we import this crate
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Do you mean for reth-rpc-eth-types = { path = "crates/rpc/rpc-eth-types", default-features = false } |
Also I cannot recommend less it can automatically detect and/or fix cases related to your last request. |
For purpose of serving EthApiErrors in RPC for sovereign rollup I use
reth-eth-types
crate.As it was fixed to using it in #10175
This PR removes approximately 42 dependencies from my tree if I use this crate without default features.
Another approach might be modifying
revm-inspectors
and have JsError not to be feature gated, so thenreth-eth-types
can import it without default features.