feat(rpc): improve error message for nonce too low #10511
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhane
requested changes
Aug 25, 2024
|
make sure to run lint with |
More descriptive line for error nonce too low Co-authored-by: Emilia Hane <emiliaha95@gmail.com>
emhane
approved these changes
Aug 25, 2024
mattsse
requested changes
Aug 26, 2024
| @@ -494,7 +503,7 @@ impl From<reth_primitives::InvalidTransactionError> for RpcInvalidTransactionErr | |||
| // txpool (e.g. `eth_sendRawTransaction`) to their corresponding RPC | |||
| match err { | |||
| InvalidTransactionError::InsufficientFunds { .. } => Self::InsufficientFunds, | |||
| InvalidTransactionError::NonceNotConsistent => Self::NonceTooLow, | |||
| InvalidTransactionError::NonceNotConsistent => Self::NonceTooLow { tx: 0, state: 0}, | |||
There was a problem hiding this comment.
I think we can also add these fields to the NonceNotConsistent error variant
reth/crates/transaction-pool/src/validate/eth.rs
Lines 338 to 344 in 29058ad
Comment on lines
240
to
242
| EVMError::Transaction(_) => EthApiError::InvalidTransaction( | ||
| RpcInvalidTransactionError::NonceTooLow { tx: 0, state: 0 } | ||
| ), |
There was a problem hiding this comment.
this doesn't look right, why this change?
DaniPopes
changed the title
…into Improve_rpc_errors @q he commit.
|
error.rs & eth.rs |
|
why was this closed @i-sangh ? this was on track and almost ready |
|
I was indeed trying to figure it out. But I'm getting errors n errors as
try to proceed.
…On Wed, Aug 28, 2024, 1:30 PM Matthias Seitz ***@***.***> wrote:
why was this closed @i-sangh <https://github.com/i-sangh> ? this was on
track and almost ready
—
Reply to this email directly, view it on GitHub
<#10511 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BJ6YPWUIBFQZFW4WSSATWXTZTV7TRAVCNFSM6AAAAABNCSAVXSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJUGYYDIOBTHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Happy to create a new branch and continue work on on this one @mattsse |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #10464. closes #10498.
The current error wasn't very helpful: nonce too low
So ideally it should now be:
nonce too low: next nonce 72, tx nonce 71