Split insert block function #10762
Open
Split insert block function #10762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elijahhampton
requested review from
rakita,
joshieDo and
shekhirin
as code owners
Rjected
requested changes
Sep 13, 2024
Rjected
reviewed
Sep 13, 2024
Rjected
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
@elijahhampton sorry for not getting back to the review in a timely manner, this looks good to me! Should just need a rebase to solve merge conflicts
elijahhampton
force-pushed
the
elijah/split-insert-block-function
branch
from
1c5a131
to
741268d
Compare
Sweet. Good to go. |
…k_additional_data.
…pt &SealedBlockWithSenders. Adds full import for DurationsRecorder. Clones signed transactions vec in place of complete block
Rjected
force-pushed
the
elijah/split-insert-block-function
branch
from
e43ab76
to
6789925
Compare
Rjected
force-pushed
the
elijah/split-insert-block-function
branch
from
6789925
to
3edc3cc
Compare
|
just trying to make sure we can merge this - I accidentally re-introduced the methods that were removed from #12367, so we just need to use the traits for those again |
Rjected
force-pushed
the
elijah/split-insert-block-function
branch
4 times, most recently
from
220068d
to
22e71e2
Compare
Rjected
force-pushed
the
elijah/split-insert-block-function
branch
from
22e71e2
to
590cd5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates two functions "insert_block_additional_data" and "insert_block_header_and_transaction_data" to split insert_block.
Fixes #9959