Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tree): avoid holding two locks simultaneously #10843

Merged
merged 2 commits into from
Sep 11, 2024
Merged

fix(tree): avoid holding two locks simultaneously #10843

merged 2 commits into from
Sep 11, 2024

Conversation

rkrasiuk
Copy link
Member

Description

Follow up to #10842. Avoid holding two locks simultaneously. Then order does not matter :)

@rkrasiuk rkrasiuk added the A-consensus Related to the consensus engine label Sep 11, 2024
@rkrasiuk rkrasiuk added the C-bug An unexpected or incorrect behavior label Sep 11, 2024
mattsse
mattsse approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

crates/chain-state/src/in_memory.rs Outdated Show resolved Hide resolved
@rkrasiuk rkrasiuk added this pull request to the merge queue Sep 11, 2024
Merged via the queue into main with commit f6444b2 Sep 11, 2024
34 checks passed
@rkrasiuk rkrasiuk deleted the rkrasiuk/avoid-holding-two-locks-simultaneously branch September 11, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

Assignees
No one assigned
Labels
A-consensus Related to the consensus engine C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkrasiuk @mattsse