Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: alias of datadir.static-files and upate book cli #10856

Merged
merged 4 commits into from
Sep 12, 2024
Merged

chore: alias of datadir.static-files and upate book cli #10856

merged 4 commits into from
Sep 12, 2024

Conversation

9547
Copy link
Contributor

@9547 9547 commented Sep 12, 2024

set an alias of datadir.static-files and also update book cli

@9547
chore(node): set alias of datadir.static-files
02c1cf9 
Signed-off-by: 9547 <29431502+9547@users.noreply.github.com>
@9547
book: update cli
62f7bac 
Signed-off-by: 9547 <29431502+9547@users.noreply.github.com>
mattsse
mattsse approved these changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, - is the right default

crates/node/core/src/args/datadir_args.rs Show resolved Hide resolved
@mattsse
Copy link
Collaborator

mattsse commented Sep 12, 2024

I think there's one more book md that we need to update

@9547
Revert "book: update cli"
5d18b09 
This reverts commit 62f7bac.

Signed-off-by: 9547 <29431502+9547@users.noreply.github.com>
@9547
book update
bb65d81 
Signed-off-by: 9547 <29431502+9547@users.noreply.github.com>
@9547
Copy link
Contributor Author

9547 commented Sep 12, 2024

I think there's one more book md that we need to update

yeah, seems the output of make update-book-cli made sth incorrect, try to find and fix it in another PR.

@mattsse mattsse added this pull request to the merge queue Sep 12, 2024
Merged via the queue into paradigmxyz:main with commit b85a4e8 Sep 12, 2024
34 checks passed
@9547 9547 deleted the arg-static-files branch September 13, 2024 00:19
@9547 9547 mentioned this pull request Sep 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@9547 @mattsse