fix(rpc): add fee/value and balance to insufficient funds RPC error #10872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhane
added
C-bug
github-actions
bot
added
the
C-debt
emhane
removed
the
C-debt
mattsse
requested changes
Sep 13, 2024
crates/transaction-pool/src/error.rs
Outdated
| )] | ||
| Overdraft { | ||
| /// Cost transaction is allowed to consume. See `reth_transaction_pool::PoolTransaction`. | ||
| value_or_fee: U256, |
There was a problem hiding this comment.
this isn't quite accurate because this is the cost this tx requires.
imo we can keep overdraft as is, this provides sufficient context
There was a problem hiding this comment.
this isn't possible if we do the conversion from overdraft error to rpc error
mattsse
requested changes
Sep 14, 2024
There was a problem hiding this comment.
okay I looked at the issue again, looks like the Overdraft field is actually what we want here cost, but InsufficientFund only includes value or fee. which can be lower than balance, so this error could be confusing to users.
this should also be the expected cost.
mattsse
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10732. Closes #10464.
Adds fee/value and balance to error message for RPC error insufficient funds.
This doesn't report the exact same error message as geth now @AntonieDavid, if that doesn't suffice an issue to revm would need to be opened to add address and gas used to error variant
https://github.com/bluealloy/revm/blob/f57e3e639ee157c7e659e740bd175a7357003570/crates/primitives/src/result.rs#L334-L336
reth/crates/rpc/rpc-eth-types/src/error.rs
Line 479 in 817b152