Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(trie): witness empty root node #10972

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

rkrasiuk
Copy link
Member

@rkrasiuk rkrasiuk commented Sep 17, 2024

Description

Add test for empty root nodes included in the witness.
Blocked by next alloy-trie release with alloy-rs/trie#36.

@rkrasiuk rkrasiuk added S-blocked This cannot more forward until something else changes C-test A change that impacts how or what we test A-trie Related to Merkle Patricia Trie implementation labels Sep 17, 2024
@rkrasiuk rkrasiuk force-pushed the rkrasiuk/test-witness-empty-root-node branch from 29c1cd1 to 663455f Compare September 26, 2024 21:24
@rkrasiuk rkrasiuk removed the S-blocked This cannot more forward until something else changes label Sep 27, 2024
@rkrasiuk rkrasiuk force-pushed the rkrasiuk/test-witness-empty-root-node branch from a2ce83a to 8823705 Compare September 27, 2024 06:34
@rkrasiuk rkrasiuk changed the title test(trie): witness empty root node fix(trie): witness empty root node Sep 27, 2024
@rkrasiuk rkrasiuk added C-bug An unexpected or incorrect behavior and removed C-test A change that impacts how or what we test labels Sep 27, 2024
@rkrasiuk rkrasiuk force-pushed the rkrasiuk/test-witness-empty-root-node branch from db15f0f to 773d6a5 Compare September 27, 2024 07:02
@rkrasiuk rkrasiuk force-pushed the rkrasiuk/test-witness-empty-root-node branch from fa18993 to 2104711 Compare September 27, 2024 16:15
@rkrasiuk rkrasiuk force-pushed the rkrasiuk/test-witness-empty-root-node branch from 787c206 to 62fcf98 Compare September 30, 2024 07:55
@rkrasiuk rkrasiuk force-pushed the rkrasiuk/test-witness-empty-root-node branch from 62fcf98 to b542309 Compare September 30, 2024 07:56
@rkrasiuk rkrasiuk added this pull request to the merge queue Sep 30, 2024
Merged via the queue into main with commit 17aa3d6 Sep 30, 2024
35 checks passed
@rkrasiuk rkrasiuk deleted the rkrasiuk/test-witness-empty-root-node branch September 30, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-trie Related to Merkle Patricia Trie implementation C-bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants