Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OptimismPayloadBuilder field visibility #11042

Merged

Conversation

0xKitsune
Copy link
Contributor

This PR updates the visibility of OptimismPayloadBuilder fields to pub. This allows custom OP stack payload builders using the OptimismPayloadBuilder as an inner type to reference these variables.

pub struct OPStackBlockBuilder<EvmConfig> {
    inner: OptimismPayloadBuilder<EvmConfig>,
}

impl<EvmConfig> OPStackBlockBuilder<EvmConfig> {
    fn build_payload(&self) {
        // --snip--
        let config = &self.inner.evm_config;
    }
}

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems fine

@mattsse mattsse added this pull request to the merge queue Sep 19, 2024
Merged via the queue into paradigmxyz:main with commit 0349d7b Sep 19, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants