Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(rpc): filter test is taking too long #11288

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Sep 27, 2024

Sometimes this test takes too long https://github.com/paradigmxyz/reth/actions/runs/11071472230/job/30763405952, there should be no need to do a hundred iterations of it.

  TRY 1 SLOW [> 30.000s] reth-rpc eth::filter::tests::test_block_range_iter
  TRY 1 SLOW [> 60.000s] reth-rpc eth::filter::tests::test_block_range_iter
  TRY 1 SLOW [> 90.000s] reth-rpc eth::filter::tests::test_block_range_iter
TRY 1 TRMNTG [>120.000s] reth-rpc eth::filter::tests::test_block_range_iter
   TRY 1 TMT [ 120.008s] reth-rpc eth::filter::tests::test_block_range_iter

--- TRY 1 STDOUT:        reth-rpc eth::filter::tests::test_block_range_iter ---

running 1 test
test eth::filter::tests::test_block_range_iter has been running for over 60 seconds

   DELAY 2/3 by   1.656s reth-rpc eth::filter::tests::test_block_range_iter
   RETRY 2/3 [         ] reth-rpc eth::filter::tests::test_block_range_iter
  TRY 2 PASS [   0.345s] reth-rpc eth::filter::tests::test_block_range_iter
------------
     Summary [ 145.657s] 786 tests run: 786 passed (1 flaky), 791 skipped
   FLAKY 2/3 [   0.345s] reth-rpc eth::filter::tests::test_block_range_iter

@shekhirin shekhirin added A-rpc Related to the RPC implementation C-test A change that impacts how or what we test labels Sep 27, 2024
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a yeah this loop is pointless

@mattsse mattsse added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit 1bbf8b6 Sep 27, 2024
36 checks passed
@mattsse mattsse deleted the alexey/rpc-filter-test-long branch September 27, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-test A change that impacts how or what we test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants