Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(exex): commit notifications to WAL before sending to ExExes #11354

Merged
merged 38 commits into from
Oct 2, 2024
Merged

feat(exex): commit notifications to WAL before sending to ExExes #11354

merged 38 commits into from
Oct 2, 2024

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Sep 30, 2024 •
edited
Loading

Closes #11322

@shekhirin shekhirin added C-enhancement New feature or request A-exex Execution Extensions labels Sep 30, 2024
@shekhirin
format with to string
bb08f5f
@shekhirin
account for finalized header when finalizing the wal
c62c64d
@shekhirin
feat(chain-state): notify about new safe/finalized only if modified
e028b70
@shekhirin
Merge remote-tracking branch 'origin/alexey/chain-info-tracker-send-i…
54e57d3 
…f-modified' into alexey/exex-wal-commit
@shekhirin
do not crash when can't find canonical notification in WAL
14ef5d4
@shekhirin
Revert "do not crash when can't find canonical notification in WAL"
e3741f3 
This reverts commit 14ef5d4.
@shekhirin
fix(exex): check exex head against node head to determine canonical
1ae103b
@shekhirin
Merge remote-tracking branch 'origin/alexey/exex-notifications-check-…
3cfd0ba 
…canonical' into alexey/exex-wal-commit
@shekhirin
Merge remote-tracking branch 'origin/main' into alexey/exex-wal-commit
71d2322
@shekhirin
Revert "revertme: use serde json again"
f7c1be1 
This reverts commit 989700b.
@shekhirin
report notification id in not found error
3b3e098
@shekhirin shekhirin marked this pull request as ready for review October 2, 2024 15:39
@shekhirin shekhirin added this pull request to the merge queue Oct 2, 2024
Merged via the queue into main with commit 16be8b9 Oct 2, 2024
35 checks passed
@shekhirin shekhirin deleted the alexey/exex-wal-commit branch October 2, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees
No one assigned
Labels
A-exex Execution Extensions C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Commit notifications to WAL before sending to ExExes
2 participants
@shekhirin @mattsse