Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(provider): handle race on fn transaction_id #11380

Merged
merged 1 commit into from
Oct 1, 2024
Merged

fix(provider): handle race on fn transaction_id #11380

merged 1 commit into from
Oct 1, 2024

Conversation

joshieDo
Copy link
Collaborator

@joshieDo joshieDo commented Oct 1, 2024

  • rename get_in_memory_or_storage_by_tx_id to get_in_memory_or_storage_by_tx and handle a transaction HashOrNumber
  • use it on BlockchainProvider2::transaction_id

@joshieDo joshieDo added C-bug An unexpected or incorrect behavior A-blockchain-tree Related to sidechains, reorgs and pending blocks labels Oct 1, 2024
mattsse
mattsse approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, this was another one

@mattsse mattsse added this pull request to the merge queue Oct 1, 2024
Merged via the queue into main with commit 22ddc98 Oct 1, 2024
36 checks passed
@mattsse mattsse deleted the joshie/txid branch October 1, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@fgimenez fgimenez Awaiting requested review from fgimenez

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

Assignees
No one assigned
Labels
A-blockchain-tree Related to sidechains, reorgs and pending blocks C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshieDo @mattsse