Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(exex): WAL size metric #11448

Merged
merged 1 commit into from
Oct 3, 2024
Merged

fix(exex): WAL size metric #11448

merged 1 commit into from
Oct 3, 2024

Conversation

shekhirin
Copy link
Collaborator

We already pass the delta, so we need to use just increment, and it will either increment or decrement the metric by the provided value.

@shekhirin shekhirin added C-bug An unexpected or incorrect behavior A-observability Related to tracing, metrics, logs and other observability tools A-exex Execution Extensions labels Oct 3, 2024
@shekhirin shekhirin added this pull request to the merge queue Oct 3, 2024
Merged via the queue into main with commit fe1f189 Oct 3, 2024
36 checks passed
@shekhirin shekhirin deleted the alexey/exex-wal-size-metric branch October 3, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo

Assignees
No one assigned
Labels
A-exex Execution Extensions A-observability Related to tracing, metrics, logs and other observability tools C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shekhirin @mattsse