Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(sdk): payload builder AT on NodeComponents and FullNodeComponents #11529

Merged
merged 3 commits into from
Nov 9, 2024
Merged

chore(sdk): payload builder AT on NodeComponents and FullNodeComponents #11529

merged 3 commits into from
Nov 9, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Oct 7, 2024

Closes #10434

@emhane emhane added the A-sdk Related to reth's use as a library label Oct 7, 2024
@github-actions github-actions bot added the C-enhancement New feature or request label Oct 7, 2024
mattsse
mattsse reviewed Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before we can do this, I'd like to explore what we'd need to do to get rid of the PayloadBuilderHandle restriction, otherwise

crates/node/builder/src/components/builder.rs Show resolved Hide resolved
@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Oct 30, 2024
@emhane emhane removed the S-stale This issue/PR is stale and will close with no further activity label Nov 5, 2024
mattsse
mattsse approved these changes Nov 9, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, with recent changes to rpcnodecore we finally have a usecase for this and we should add finally add this

lgtm

@mattsse mattsse added this pull request to the merge queue Nov 9, 2024
Merged via the queue into main with commit a299f50 Nov 9, 2024
41 checks passed
@mattsse mattsse deleted the emhane/payload-builder-comp branch November 9, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

Assignees
No one assigned
Labels
A-sdk Related to reth's use as a library C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Promote PayloadBuilder to component type
2 participants
@emhane @mattsse