Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap sidecar in arcs #11554

Merged
merged 26 commits into from
Oct 30, 2024
Merged

Wrap sidecar in arcs #11554

merged 26 commits into from
Oct 30, 2024

Conversation

kdonthi
Copy link
Contributor

@kdonthi kdonthi commented Oct 7, 2024 •
edited by mattsse
Loading

ref #11460

mattsse
mattsse requested changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is looking great already.

crates/transaction-pool/src/lib.rs Outdated Show resolved Hide resolved
crates/transaction-pool/src/blobstore/disk.rs Outdated Show resolved Hide resolved
@mattsse mattsse added C-perf A change motivated by improving speed, memory usage or disk footprint A-tx-pool Related to the transaction mempool labels Oct 8, 2024
@kdonthi kdonthi marked this pull request as ready for review October 9, 2024 21:10
@kdonthi kdonthi requested a review from Rjected as a code owner October 9, 2024 21:10
@kdonthi kdonthi requested a review from mattsse October 9, 2024 21:29
mattsse
mattsse approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty, lgtm

need to do one final check before merging

@mattsse
Copy link
Collaborator

mattsse commented Oct 17, 2024

does not compile yet though, looks like one function needs to be migrated

@kdonthi
Merge branch 'refs/heads/main' into wrap-sidecare-in-arcs
0962d21 
# Conflicts:
#	crates/transaction-pool/src/blobstore/disk.rs
#	crates/transaction-pool/src/blobstore/mem.rs
@kdonthi
fix issues?
7161af1
@kdonthi kdonthi requested a review from gakonst as a code owner October 24, 2024 19:22
@kdonthi kdonthi requested a review from mattsse October 24, 2024 19:50
@kdonthi
Copy link
Contributor Author

kdonthi commented Oct 24, 2024 •
edited
Loading

I ran the unit tests and lint🤞 (although some of the unit tests don't work in the Makefile script, and I have to run them individually like test_drop_lock, test_lock, test_header_truncation and test_tx_based_truncation)

Rjected
Rjected reviewed Oct 24, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would like one smol change, otherwise lgtm

testing/testing-utils/src/generators.rs Outdated Show resolved Hide resolved
@Rjected Rjected changed the title Wrap sidecare in arcs Wrap sidecar in arcs Oct 25, 2024
Rjected
Rjected approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mattsse
mattsse approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,

sorry about the delay.

I applied some updates: Arc::unwrap_or_clone which makes the (*).clone a bit nicer

@mattsse mattsse added this pull request to the merge queue Oct 30, 2024
Merged via the queue into paradigmxyz:main with commit 755fac0 Oct 30, 2024
40 checks passed
@mattsse mattsse mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Rjected approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-tx-pool Related to the transaction mempool C-perf A change motivated by improving speed, memory usage or disk footprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kdonthi @mattsse @Rjected