chore(rpc): use block_hash as BlockId on eth_callMany
#11595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Oct 9, 2024
Comment on lines
250
to
255
| let block_number = block_number.unwrap_or_default(); | ||
| let target_block: BlockId = LoadBlock::provider(self) | ||
| .block_hash_for_id(block_number) | ||
| .map_err(|_| EthApiError::HeaderNotFound(block_number))? | ||
| .ok_or_else(|| EthApiError::HeaderNotFound(block_number))? | ||
| .into(); |
There was a problem hiding this comment.
this does not really work for the pending block.
so we can only do this if this is not pending
mattsse
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
similar to #11587
reth/crates/rpc/rpc-eth-api/src/helpers/call.rs
Lines 250 to 256 in 1e1de3d
otherwise
evm_env_at&block_with_senderswill each one have its own view of whatblock_numberis which might be different on a ill timed reorg