-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace receipt envelope encoded with trait #11742
Conversation
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
what needs to be changed here @Rjected ? I also don't fully know |
I think an let mut payload_len = self.receipt_length();
// account for eip-2718 type prefix and set the list
if !matches!(self.receipt.tx_type, TxType::Legacy) {
// we do NOT include a string header for 2718 envelope encoded receipts, but we do need to include the 2718 type byte
payload_len += 1;
}
payload_len |
# Conflicts: # crates/primitives/src/receipt.rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some nits, otherwise this looks good, thanks for adding the tests!
Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com>
hi @Rjected please help me review it, thank |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
hi @mattsse help me review it, thank sir |
Closed #11737