Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: change net::discv5 log target to discv5 #12045

Merged
merged 1 commit into from
Oct 25, 2024
Merged

chore: change net::discv5 log target to discv5 #12045

merged 1 commit into from
Oct 25, 2024

Conversation

PanGan21
Copy link
Contributor

@PanGan21 PanGan21 commented Oct 24, 2024 •
edited by mattsse
Loading

closes: #12043
Changes log target of discv5 logs from net::discv5 to discv5

@PanGan21 PanGan21 mentioned this pull request Oct 24, 2024
Closed
mattsse
mattsse approved these changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse added this pull request to the merge queue Oct 25, 2024
@mattsse mattsse added the A-observability Related to tracing, metrics, logs and other observability tools label Oct 25, 2024
Merged via the queue into paradigmxyz:main with commit 674616c Oct 25, 2024
39 checks passed
@zilayo zilayo mentioned this pull request Oct 28, 2024
Merged
zilayo added a commit to zilayo/reth that referenced this pull request Oct 28, 2024
@zilayo
Revert "chore: change net::discv5 log target to discv5 (paradigmx…
0f9fcf0 
…yz#12045)"

This reverts commit 674616c.

The discv5 crate logs are too verbose, so reth's discv5 tracing target needs a seperate namespace.
github-merge-queue bot pushed a commit that referenced this pull request Oct 29, 2024
@zilayo
fix: use net::discv5 for reth's discv5 tracing target namespace (reve…
0297b8f 
…rts #12045) (#12151)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@emhane emhane Awaiting requested review from emhane emhane is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-observability Related to tracing, metrics, logs and other observability tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change log target of discv5 logs from net::discv5 to discv5
2 participants
@PanGan21 @mattsse