chore(rpc): Remove provider and network trait methods from EthApiSpec
#12050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhane
added
C-debt
mattsse
approved these changes
Oct 26, 2024
Comment on lines
+17
to
+25
| pub trait EthApiSpec: | ||
| RpcNodeCore< | ||
| Provider: ChainSpecProvider<ChainSpec: EthereumHardforks> | ||
| + BlockNumReader | ||
| + StageCheckpointReader, | ||
| Network: NetworkInfo, | ||
| > + Send | ||
| + Sync | ||
| { |
There was a problem hiding this comment.
cool, I like this a lot, this allows us to extend the RpcNodeCore internals as we see fit, which will be important to tackle #12023
github-actions
bot
requested review from
onbjerg,
rkrasiuk and
gakonst
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #11422
Based on #10616
Removes
EthApiSpec::providerandEthApiSpec::network, by addingRpcNodeCoreas super trait toEthApiSpec.