Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clippy lints #12269

Merged
merged 2 commits into from
Nov 2, 2024
Merged

fix: clippy lints #12269

merged 2 commits into from
Nov 2, 2024

Conversation

klkvr
Copy link
Collaborator

@klkvr klkvr commented Nov 2, 2024 •
edited
Loading

this currently causes make lint to fail locally

I've updated lint workflows to run checks over tests and benches too so that we catch such issues in CI

@mattsse mattsse added this pull request to the merge queue Nov 2, 2024
@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Nov 2, 2024
Merged via the queue into main with commit d7ead13 Nov 2, 2024
41 checks passed
@mattsse mattsse deleted the klkvr/fix-make-lint branch November 2, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

Assignees
No one assigned
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klkvr @mattsse