Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(sdk): define helper trait FullNodePrimitives #12331

Merged
merged 11 commits into from
Nov 11, 2024
Merged

chore(sdk): define helper trait FullNodePrimitives #12331

merged 11 commits into from
Nov 11, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Nov 5, 2024

Based on #12326, #12330, #12327

@emhane emhane added C-debt Refactor of code section that is hard to understand or maintain A-sdk Related to reth's use as a library labels Nov 5, 2024
@emhane emhane added the S-blocked This cannot more forward until something else changes label Nov 5, 2024
@emhane emhane mentioned this pull request Nov 6, 2024
Open
Base automatically changed from emhane/node-primitives to main November 9, 2024 09:35
@emhane emhane requested a review from fgimenez as a code owner November 9, 2024 09:35
@emhane emhane removed the S-blocked This cannot more forward until something else changes label Nov 10, 2024
mattsse
mattsse approved these changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@emhane emhane added this pull request to the merge queue Nov 11, 2024
Merged via the queue into main with commit 5d5f442 Nov 11, 2024
41 checks passed
@emhane emhane deleted the emhane/full-node-primitives branch November 11, 2024 12:16
@emhane emhane mentioned this pull request Nov 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-sdk Related to reth's use as a library C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emhane @mattsse