refactor(rpc): unify system caller invocations #12360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Nov 7, 2024
Comment on lines
+453
to
+458
| /// Applies chain-specific state transitions required before executing a block. | ||
| /// | ||
| /// Note: This should only be called when tracing an entire block vs individual transactions. | ||
| /// When tracing transaction on top of an already committed block state, those transitions are | ||
| /// already applied. | ||
| fn apply_pre_execution_changes<DB: Send + Database<Error: Display> + DatabaseCommit>( |
There was a problem hiding this comment.
this makes sense, although this only works as long as the the system calls are the same for eth and op.
but this is a good step
| @@ -93,54 +92,30 @@ where | |||
| /// Trace the entire block asynchronously | |||
| async fn trace_block( | |||
| &self, | |||
| at: BlockId, | |||
| transactions: Vec<TransactionSignedEcRecovered>, | |||
| block: Arc<SealedBlockWithSenders>, | |||
There was a problem hiding this comment.
these changes are so that we don't need the parent_beacon_block_root argument?
Comment on lines
-223
to
+192
| transactions, | ||
| Arc::new(block.with_senders_unchecked(senders).seal_slow()), |
There was a problem hiding this comment.
I see we need to seal here because we decoded the block from rlp
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #12023
Extracts all system caller into a separate method on
Tracetrait. Those are now same for OP and eth but eventually we can customize OP behavior by just overriding this method in OP trait impl.