Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce ParallelProof #12403

Merged
merged 2 commits into from
Nov 8, 2024
Merged

feat: introduce ParallelProof #12403

merged 2 commits into from
Nov 8, 2024

Conversation

fgimenez
Copy link
Member

@fgimenez fgimenez commented Nov 8, 2024

Towards #12053

Extracted from #11154, the main change is not using BlockingTaskPool (which internally uses rayon) and instead spawns using rayon directly, this allows us to use std::sync::mpsc::sync_channel to receive storage root results instead of the async tokio channel associated with BlockingTaskPool. With this the multiproof method doesn't need to be async (the only .await was used for getting storage results on the async channel).

@fgimenez fgimenez added C-enhancement New feature or request A-consensus Related to the consensus engine A-trie Related to Merkle Patricia Trie implementation labels Nov 8, 2024
Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fgimenez fgimenez added this pull request to the merge queue Nov 8, 2024
Merged via the queue into main with commit f03b762 Nov 8, 2024
41 checks passed
@fgimenez fgimenez deleted the fgimenez/srt-parallel-proof branch November 8, 2024 15:37
@fgimenez fgimenez added the C-perf A change motivated by improving speed, memory usage or disk footprint label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-consensus Related to the consensus engine A-trie Related to Merkle Patricia Trie implementation C-enhancement New feature or request C-perf A change motivated by improving speed, memory usage or disk footprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants