Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make PayloadStore operate on PayloadBuilder #12460

Merged
merged 3 commits into from
Nov 12, 2024
Merged

make PayloadStore operate on PayloadBuilder #12460

merged 3 commits into from
Nov 12, 2024

Conversation

stevencartavia
Copy link
Contributor

@stevencartavia stevencartavia commented Nov 12, 2024 •
edited by mattsse
Loading

closes #12422

@mattsse mattsse marked this pull request as ready for review November 12, 2024 11:38
mattsse
mattsse approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

I've erased the error type by introducing a helper trait

@mattsse mattsse added this pull request to the merge queue Nov 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 12, 2024
@mattsse mattsse merged commit c44edf5 into paradigmxyz:main Nov 12, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@emhane emhane Awaiting requested review from emhane emhane is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make PayloadStore operate on trait PayloadBuilder
2 participants
@stevencartavia @mattsse