Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move (Full)NodePrimitives to reth-primitive-traits #12461

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Conversation

joshieDo
Copy link
Collaborator

Allows it to be imported on other crates without any cyclical dependencies. eg. storage-api

@joshieDo joshieDo added the A-sdk Related to reth's use as a library label Nov 12, 2024
@joshieDo joshieDo requested a review from emhane November 12, 2024 07:46
@joshieDo joshieDo changed the title feat: move (Full)NodePrimitives to reth-primitive-traits chore: move (Full)NodePrimitives to reth-primitive-traits Nov 12, 2024
crates/primitives-traits/src/node.rs Outdated Show resolved Hide resolved
Co-authored-by: Emilia Hane <elsaemiliaevahane@gmail.com>
@joshieDo joshieDo added this pull request to the merge queue Nov 12, 2024
Merged via the queue into main with commit f38503c Nov 12, 2024
40 checks passed
@joshieDo joshieDo deleted the joshie/mvnp branch November 12, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sdk Related to reth's use as a library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants