Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make downloaders and clients generic over block parts #12469

Merged
merged 9 commits into from
Nov 12, 2024

Conversation

klkvr
Copy link
Collaborator

@klkvr klkvr commented Nov 12, 2024

  • Makes some of the network types and components generic over NetworkPrimitives This includes EthStream, messages and fetcher
  • Adds header and body AT to block clients/downloaders. For now the common implementations mostly rely on alloy_consensus::BlockHeader for header and InMemorySize for body which should allow to reuse those for most of the networks.
  • More high-level consumers rely on EthBlockClient which restricts clients to Ethereum block parts

@mattsse mattsse added C-enhancement New feature or request A-sdk Related to reth's use as a library labels Nov 12, 2024
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, one step closer.

ci has smol complaints

likely unrelated to this pr

@mattsse mattsse added this pull request to the merge queue Nov 12, 2024
Merged via the queue into main with commit aece53a Nov 12, 2024
41 checks passed
@mattsse mattsse deleted the klkvr/generic-downloaders branch November 12, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sdk Related to reth's use as a library C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants