chore: Update Holocene timestamp for Sepolia #12479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clabby
requested review from
mattsse,
Rjected,
fgimenez and
emhane
as code owners
clabby
force-pushed
the
cl/holocene-sepolia
branch
from
156e877
to
0e5f595
Compare
mattsse
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
lgtm
looks like we only need to update the forkhash?
thread 'tests::base_sepolia_forkids' panicked at crates/chainspec/src/spec.rs:936:9:
assertionleft == rightfailed: Expected fork ID ForkId { hash: ForkHash("595e2e6e"), next: 0 }, computed fork ID ForkId { hash: ForkHash("8b5e7629"), next: 0 } at block 0
onbjerg
approved these changes
Nov 12, 2024
ah whoops - fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
#12453 added the timestamps for {OP/Base} Sepolia activation, but they were changed to allow for RaaS providers to have a bit more time to prepare for the upgrade. See ethereum-optimism/superchain-registry#677