feat: relax BodyStage bounds
#12539
Merged
feat: relax BodyStage bounds
#12539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
requested review from
rakita,
joshieDo,
shekhirin,
onbjerg,
rkrasiuk and
Rjected
as code owners
mattsse
approved these changes
Nov 14, 2024
Comment on lines
+1061
to
+1062
| #[cfg(any(test, feature = "reth-codec"))] | ||
| impl reth_codecs::Compact for TransactionSigned { |
There was a problem hiding this comment.
imo this makes sense
especially if we do
this also isn't more expensive because this just does the clone somewhere else
There was a problem hiding this comment.
this makes sense for now imo
it's easier to gradually add them back,
could you open an issue with the removed code snippet so we have it at hand and can track what else we might want to add?
There was a problem hiding this comment.
yep, tracking in #12544
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR:
BlockBodyto only what's required right now and implement it forBlockBodyToCompactforTransactionSignedthrough conversion toTransactionSignedNoHash. The clone should be cheap enough and should be cleaned up soon by Remove TransactionSignedNoHash type #12471BodyAT toBlockWriterand set it to primitive block body in current implementation.Body = reth_primitives::BlockBodyforBodyStage. This allows the stage to be used for any block bodies as long as the db provider can write them to databaseNext step would be to replace
BodyAT forBlockWriterimplementation with Block from primitives and delegate writing it to database toChainStorageWriterfrom #11243