Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): limit FillTxEnv to super trait of FullSignedTx #12614

Merged
merged 4 commits into from
Nov 18, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Nov 17, 2024

FillTxEnv is only necessary in rpc (tracing) and execution components

@emhane emhane added C-debt Refactor of code section that is hard to understand or maintain A-execution Related to the Execution and EVM A-sdk Related to reth's use as a library labels Nov 17, 2024
@emhane emhane requested a review from gakonst as a code owner November 18, 2024 21:02
@emhane emhane added this pull request to the merge queue Nov 18, 2024
Merged via the queue into main with commit 641d128 Nov 18, 2024
41 checks passed
@emhane emhane deleted the emhane/fill-tx-env branch November 18, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-execution Related to the Execution and EVM A-sdk Related to reth's use as a library C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants