Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(db): Add libmdbx-rs apache licenced code 55e234 #132

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

rakita
Copy link
Collaborator

@rakita rakita commented Oct 25, 2022

Added Apache version of libmdbx-rs (commit: 55e234) from https://github.com/vorot93/libmdbx-rs.

This pull request is here to just include the code in a clean way, next pull request will use the lib and update mdbx-sys.

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #132 (c17ab81) into main (0998fc3) will increase coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
+ Coverage   70.98%   71.11%   +0.13%     
==========================================
  Files         140      140              
  Lines        9361     9386      +25     
==========================================
+ Hits         6645     6675      +30     
+ Misses       2716     2711       -5     
Impacted Files Coverage Δ
crates/db/src/kv/cursor.rs 27.38% <0.00%> (-0.33%) ⬇️
crates/db/src/kv/mod.rs 93.45% <0.00%> (+0.55%) ⬆️
crates/interfaces/src/db/container.rs 52.94% <0.00%> (+1.51%) ⬆️
crates/interfaces/src/db/codecs/fuzz/mod.rs 86.66% <0.00%> (+2.05%) ⬆️
crates/interfaces/src/db/mod.rs 69.69% <0.00%> (+5.80%) ⬆️
crates/interfaces/src/db/models/blocks.rs 94.33% <0.00%> (+9.72%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,

next step is then to replace crate dependencies?

@rakita rakita merged commit 4d2e67e into main Oct 25, 2022
@rakita rakita deleted the rakita/appache_limdbx branch October 25, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants