Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: jemalloc and process metrics in Grafana dashboard #3455

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Jun 28, 2023

Follow-up to #3435. All these metrics work independently from prometheus-node-exporter, so even if the user doesn't have it installed, they can still get some useful info on resource usage.

image

(CPU spike is the senders recovery stage which is highly parallelizable)

@shekhirin shekhirin marked this pull request as ready for review June 28, 2023 19:45
@shekhirin shekhirin requested a review from gakonst as a code owner June 28, 2023 19:45
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #3455 (9485b0e) into main (6b8b478) will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

see 16 files with indirect coverage changes

Flag Coverage Δ
integration-tests 12.62% <ø> (-0.03%) ⬇️
unit-tests 64.23% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 23.04% <ø> (-0.42%) ⬇️
blockchain tree 81.69% <ø> (ø)
pipeline 86.75% <ø> (ø)
storage (db) 73.01% <ø> (ø)
trie 95.64% <ø> (ø)
txpool 52.01% <ø> (ø)
networking 77.20% <ø> (-0.24%) ⬇️
rpc 49.15% <ø> (ø)
consensus 63.00% <ø> (ø)
revm 34.29% <ø> (ø)
payload builder 4.36% <ø> (ø)
primitives 87.14% <ø> (-0.04%) ⬇️

@shekhirin shekhirin added A-meta Changes in the contributor workflow and planning C-enhancement New feature or request labels Jun 28, 2023
@gakonst gakonst added this pull request to the merge queue Jun 28, 2023
Merged via the queue into main with commit 41ac27b Jun 28, 2023
@gakonst gakonst deleted the alexey/process-jemalloc-grafana branch June 28, 2023 23:23
@onbjerg onbjerg added the M-changelog This change should be included in the changelog label Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Changes in the contributor workflow and planning C-enhancement New feature or request M-changelog This change should be included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants