feat: make rpc gas cap configurable #3458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
... and 9 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mattsse
reviewed
Jun 29, 2023
onbjerg
added
C-enhancement
shekhirin
reviewed
Jul 10, 2023
| @@ -132,6 +135,10 @@ pub struct RpcServerArgs { | |||
| #[arg(long, value_name = "COUNT", default_value_t = RPC_DEFAULT_MAX_TRACING_REQUESTS)] | |||
| pub rpc_max_tracing_requests: u32, | |||
|
|
|||
| /// Maximum gas limit for `eth_call` and call tracing RPC methods. | |||
| #[arg(long = "rpc.gascap", value_name = "GAS_CAP", default_value_t = RPC_DEFAULT_GAS_CAP)] | |||
| pub rpc_gas_cap: u64, | |||
There was a problem hiding this comment.
Next, to be able to use this parameter in EVM, we need to pass it to the RPC implementations in the same way as we do with max_log_per_response in EthFilter:
reth/crates/rpc/rpc-builder/src/lib.rs
Line 976 in a7f32db
So:
- Add
rpc_gas_captoEthConfig. - Pass
EthConfig.rpc_gas_captoEthApi,DebugApiandTraceApi. - Pass the gas cap to
prepare_call_envvia new function argument.
Co-authored-by: Alexey Shekhirin <a.shekhirin@gmail.com>
mattsse
approved these changes
Jul 17, 2023
mattsse
force-pushed
the
leovct/feat-make-rpc-gas-cap-configurable
branch
from
73cc56f
to
3930e81
Compare
mattsse
force-pushed
the
leovct/feat-make-rpc-gas-cap-configurable
branch
from
3930e81
to
310ac8b
Compare
merklefruit
pushed a commit
to merklefruit/op-reth-old
that referenced
this pull request
Jul 26, 2023
Co-authored-by: Alexey Shekhirin <a.shekhirin@gmail.com> Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
merklefruit
pushed a commit
to anton-rs/op-reth
that referenced
this pull request
Jul 27, 2023
Co-authored-by: Alexey Shekhirin <a.shekhirin@gmail.com> Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3309
rpc-gas-capwith default value set toETHEREUM_BLOCK_GAS_LIMIT(=30_000_000).rpc-gas-capin addition to the CLI arg