Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make chain canonical if new payload is the missing block for current sync target #3459

Merged
merged 2 commits into from
Jun 30, 2023
Merged

feat: make chain canonical if new payload is the missing block for current sync target #3459

merged 2 commits into from
Jun 30, 2023

Conversation

int88
Copy link
Contributor

@int88 int88 commented Jun 29, 2023 •
edited by onbjerg
Loading

Closes #2944

@codecov
Copy link

codecov bot commented Jun 29, 2023 •
edited
Loading

Codecov Report

Merging #3459 (c99e256) into main (bb57556) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

Impacted Files Coverage Δ
crates/consensus/beacon/src/engine/forkchoice.rs 47.88% <ø> (ø)
crates/consensus/beacon/src/engine/mod.rs 78.28% <ø> (-0.78%) ⬇️

... and 52 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.27% <ø> (-0.02%) ⬇️
unit-tests 64.24% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 23.05% <ø> (-0.40%) ⬇️
blockchain tree 81.69% <ø> (+0.32%) ⬆️
pipeline 87.88% <ø> (-0.14%) ⬇️
storage (db) 73.93% <ø> (-0.06%) ⬇️
trie 95.64% <ø> (ø)
txpool 51.82% <ø> (+0.45%) ⬆️
networking 77.92% <ø> (+0.01%) ⬆️
rpc 58.11% <ø> (+0.05%) ⬆️
consensus 62.78% <ø> (-0.30%) ⬇️
revm 35.07% <ø> (-0.07%) ⬇️
payload builder 6.83% <ø> (ø)
primitives 88.70% <ø> (+0.09%) ⬆️

@int88
Copy link
Contributor Author

int88 commented Jun 29, 2023

@mattsse PTAL :)

@onbjerg onbjerg added C-enhancement New feature or request A-blockchain-tree Related to sidechains, reorgs and pending blocks labels Jun 29, 2023
mattsse
mattsse approved these changes Jun 30, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, this is great

@mattsse mattsse enabled auto-merge June 30, 2023 11:24
@mattsse mattsse added this pull request to the merge queue Jun 30, 2023
Merged via the queue into paradigmxyz:main with commit 5c7d5a3 Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-blockchain-tree Related to sidechains, reorgs and pending blocks C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make chain canonical if new payload is the missing block for current sync target
3 participants
@int88 @mattsse @onbjerg