Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename invalid header metrics scope #3468

Merged
merged 2 commits into from
Jun 29, 2023
Merged

chore: rename invalid header metrics scope #3468

merged 2 commits into from
Jun 29, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jun 29, 2023

Closes #3411

rename scope and put it under existing consensus.engine.beacon scope

@mattsse mattsse added the A-observability Related to tracing, metrics, logs and other observability tools label Jun 29, 2023
@rkrasiuk rkrasiuk changed the title chore: rename invalid header metrics scop chore: rename invalid header metrics scope Jun 29, 2023
@mattsse mattsse enabled auto-merge June 29, 2023 15:21
@codecov
Copy link

codecov bot commented Jun 29, 2023 •
edited
Loading

Codecov Report

Merging #3468 (ab0ca5a) into main (26b80f4) will decrease coverage by 15.25%.
The diff coverage is 66.66%.

Impacted file tree graph

Impacted Files Coverage Δ
...tes/consensus/beacon/src/engine/invalid_headers.rs 38.59% <66.66%> (-35.09%) ⬇️

... and 193 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.26% <0.00%> (-0.03%) ⬇️
unit-tests 47.48% <66.66%> (-16.79%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 17.15% <ø> (-5.87%) ⬇️
blockchain tree 78.63% <ø> (-3.07%) ⬇️
pipeline 67.93% <ø> (-19.96%) ⬇️
storage (db) 61.06% <ø> (-13.12%) ⬇️
trie 74.56% <ø> (-21.08%) ⬇️
txpool 39.45% <ø> (-11.92%) ⬇️
networking 60.62% <ø> (-17.40%) ⬇️
rpc 45.97% <ø> (-12.15%) ⬇️
consensus 45.79% <66.66%> (-17.00%) ⬇️
revm 26.69% <ø> (-8.45%) ⬇️
payload builder 6.83% <ø> (ø)
primitives 64.82% <ø> (-23.85%) ⬇️

@mattsse mattsse added this pull request to the merge queue Jun 29, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 29, 2023
@mattsse mattsse force-pushed the matt/change-invalid-header-scpe branch from 104ea9c to 9aa3df9 Compare June 29, 2023 16:55
@mattsse mattsse enabled auto-merge June 29, 2023 17:52
@onbjerg onbjerg added C-enhancement New feature or request C-bug An unexpected or incorrect behavior M-changelog This change should be included in the changelog and removed C-enhancement New feature or request labels Jun 29, 2023
@onbjerg onbjerg mentioned this pull request Jun 29, 2023
Closed
@mattsse mattsse force-pushed the matt/change-invalid-header-scpe branch from 9aa3df9 to 08e5b21 Compare June 29, 2023 20:38
@mattsse mattsse force-pushed the matt/change-invalid-header-scpe branch from 1f5e9ce to ab0ca5a Compare June 29, 2023 21:38
@mattsse mattsse added this pull request to the merge queue Jun 29, 2023
Merged via the queue into main with commit 0205938 Jun 29, 2023
@mattsse mattsse deleted the matt/change-invalid-header-scpe branch June 29, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@onbjerg onbjerg onbjerg approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-observability Related to tracing, metrics, logs and other observability tools C-bug An unexpected or incorrect behavior M-changelog This change should be included in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rename invalid headers metric namespace
3 participants
@mattsse @onbjerg @rkrasiuk