Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename invalid header metrics scope #3468

Merged
merged 2 commits into from
Jun 29, 2023
Merged

chore: rename invalid header metrics scope #3468

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
124f362
chore: rename invalid header metrics scop
mattsse Jun 29, 2023
ab0ca5a
rename field
mattsse Jun 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions crates/consensus/beacon/src/engine/invalid_headers.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ impl InvalidHeaderCache {

// update metrics
self.metrics.known_ancestor_inserts.increment(1);
self.metrics.invalid_headers.set(self.headers.len() as f64);
self.metrics.count.set(self.headers.len() as f64);
}
}

Expand All @@ -74,7 +74,7 @@ impl InvalidHeaderCache {

// update metrics
self.metrics.unique_inserts.increment(1);
self.metrics.invalid_headers.set(self.headers.len() as f64);
self.metrics.count.set(self.headers.len() as f64);
}
}
}
Expand All @@ -88,10 +88,10 @@ struct HeaderEntry {

/// Metrics for the invalid headers cache.
#[derive(Metrics)]
#[metrics(scope = "invalid_header_cache")]
#[metrics(scope = "consensus.engine.beacon.invalid_headers")]
struct InvalidHeaderCacheMetrics {
/// The total number of invalid headers in the cache.
invalid_headers: Gauge,
count: Gauge,
/// The number of inserts with a known ancestor.
known_ancestor_inserts: Counter,
/// The number of unique invalid header inserts (i.e. without a known ancestor).
Expand Down